gRPC minor enhancements #1277
Merged
gRPC minor enhancements #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
requested changes
Jan 13, 2020
grpc/client/src/main/java/io/helidon/grpc/client/GrpcChannelDescriptor.java
Outdated
Show resolved
Hide resolved
grpc/client/src/main/java/io/helidon/grpc/client/GrpcChannelDescriptor.java
Outdated
Show resolved
Hide resolved
tomas-langer
previously approved these changes
Jan 14, 2020
…ndency on helidon-microprofile-metrics should have a scope of provided. Allow a gRPC service descriptors to be created without needing a BeanManager. Support creating gRPC Channels configured for a target URI in addition to a host and port.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor enhancements to the gRPC support based on feedback whilst using Helidon gRPC to build the Coherence gRPC server and clients.