Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples to demonstrate the proper way to write files using NIO #2844

Closed
romain-grecourt opened this issue Mar 9, 2021 · 1 comment · Fixed by #6604
Closed

Update examples to demonstrate the proper way to write files using NIO #2844

romain-grecourt opened this issue Mar 9, 2021 · 1 comment · Fixed by #6604
Assignees
@danielkec @romain-grecourt
Labels
examples P3 SE

Comments

@romain-grecourt
Copy link
Contributor

This is a follow-up on #2830

Update SE examples that write files using NIO. If they are blocking the event-loop, update them to use a dedicated thread pool, if they are reactive make them use the tooling to be created as part of #2840

  • Update FileService under examples/media/multipart
  • Update examples/webserver/streaming
@romain-grecourt romain-grecourt self-assigned this Mar 9, 2021
@romain-grecourt
Copy link
Contributor Author

CC @tomas-langer

@romain-grecourt romain-grecourt mentioned this issue Mar 9, 2021
Merged
@m0mus m0mus added P3 and removed P2 labels Jun 17, 2021
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Apr 12, 2023
@romain-grecourt
Update streaming example to use IoMulti to demonstrate proper NIO usage.
d1031db 
Fixes helidon-io#2844
@romain-grecourt romain-grecourt mentioned this issue Apr 12, 2023
Merged
romain-grecourt added a commit that referenced this issue Apr 14, 2023
@romain-grecourt
Update streaming example to use IoMulti to demonstrate proper NIO usa…
72a9299 
…ge. (#6604)

Fixes #2844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielkec danielkec

@romain-grecourt romain-grecourt

Labels
examples P3 SE
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update streaming example to use IoMulti romain-grecourt/helidon
3 participants
@danielkec @romain-grecourt @m0mus