Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] h1 page title has parent group title instead of parent path element #90

Closed
wants to merge 2 commits into from

Conversation

danielkec
Copy link
Contributor

When referencing documents from shared folder, h1 title parent is derived from parent path element:
image
Use parent group title from navigation like this:
image

Signed-off-by: Daniel Kec daniel.kec@oracle.com

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec changed the title h1 page title has parent group title instead of parent path element [WIP] h1 page title has parent group title instead of parent path element Mar 31, 2020
@romain-grecourt
Copy link
Contributor

romain-grecourt commented Mar 31, 2020

Your first screenshot does not show the route, but based on your changes seems that you are changing the routes.

I'm guessing that you are including an .adoc file in the navigation from something like shared/.

  • Is this file supposed to be included in-place in the navigation multiple times ?
  • Or is is supposed to be included using an include directive in two documents that have different titles and routes ?

The route in your screenshot is like this: #/se/reactivestreams/02_engine/Reactive+Streams.
Why is there an extra slash between engine and reactive ?

The current way of computing the routes based on path has some major flaws, (e.g. the nav order based on filename), however the routes should still be based on the file path.

It seems that you are trying to base the route of the navigation hierarchy because you are including something for shared/ directly in the navigation under Reactive Streams. Can you try instead to have a document under reactivestreams/ that uses an includes directive to include content from shared/ ?

@danielkec
Copy link
Contributor Author

@romain-grecourt I've been trying to avoid an extra doc with includes by smuggling parent group title as a path param(Reactive+Streams is escaped goup.title from navigation), so I can use it in h1 title. It almost worked, but assciidoc internal links got broken horribly so I'm going back to the intermediate adoc with include reference as you suggest.

@romain-grecourt
Copy link
Contributor

Yeah, the current implementation is far from perfect, and touching the routes will have tons of side effects.

@danielkec danielkec closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants