Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helidon init - add defaults in case of the user has not specify mandatory options #776

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

aserkes
Copy link
Contributor

@aserkes aserkes commented Aug 19, 2022

Resolve bad project directory name and incorrect package names with implicit defaults in batch mode

Resolves #774

Signed-off-by: aserkes andrii.serkes@oracle.com

Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes self-assigned this Aug 19, 2022
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test to test this case ?

…r without external default values) in Context

Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes merged commit 8d32446 into helidon-io:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helidon init: bad project directory name with implicit defaults in batch mode
2 participants