Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and wheel for Python 3.12 #42

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

StephenOman
Copy link
Collaborator

Gymnasium v1.0.0 supports Python 3.12, so this PR adds that Python version to the test matrix & includes a wheel on release build.

@StephenOman StephenOman added the enhancement New feature or request label Oct 19, 2024
Copy link
Owner

@heiner heiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but I'm unsure why this test is unhappy:

ls: cannot access 'dist/*311*manylinux*x86_64*.whl': No such file or directory

@StephenOman
Copy link
Collaborator Author

Oh I think I know what that is. I bumped up the version of the wheel generated to 3.12. However, the later wheel test is looking for the 3.11 version, which is no longer generated during the run.

@heiner
Copy link
Owner

heiner commented Oct 20, 2024

Python's build system ecosystem is (1) kinda broken, and (2) in flux. It looks like we need to add a dependency on setuptools for 3.12 somewhere?

I'd be interested in reconsidering how we build NLE and switch to uv, but I'm a bit short on time these days. Thanks for your amazing work @StephenOman btw!

@StephenOman
Copy link
Collaborator Author

Yeah this is proving a bit tricky. Fix one thing, break something else!

Thanks @heiner for your kind words!

@StephenOman
Copy link
Collaborator Author

As per the release notes for Python 3.12, setuptools is no longer installed by default in Python virtual environments. So it has to be installed explicitly in the virtual environment preparation. It's not necessary for the earlier versions of Python, but I've added it to all the virtual environments for consistency.

Copy link
Owner

@heiner heiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@StephenOman StephenOman merged commit 3531028 into main Oct 30, 2024
22 checks passed
@StephenOman StephenOman deleted the add-python3-12-support branch October 30, 2024 08:03
@StephenOman
Copy link
Collaborator Author

This PR addresses issue #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants