-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and wheel for Python 3.12 #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good but I'm unsure why this test is unhappy:
ls: cannot access 'dist/*311*manylinux*x86_64*.whl': No such file or directory
Oh I think I know what that is. I bumped up the version of the wheel generated to 3.12. However, the later wheel test is looking for the 3.11 version, which is no longer generated during the run. |
Python's build system ecosystem is (1) kinda broken, and (2) in flux. It looks like we need to add a dependency on setuptools for 3.12 somewhere? I'd be interested in reconsidering how we build NLE and switch to |
Yeah this is proving a bit tricky. Fix one thing, break something else! Thanks @heiner for your kind words! |
As per the release notes for Python 3.12, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
This PR addresses issue #39 |
Gymnasium v1.0.0 supports Python 3.12, so this PR adds that Python version to the test matrix & includes a wheel on release build.