Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing teams from escalation policy #25

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Fix removing teams from escalation policy #25

merged 1 commit into from
Apr 19, 2019

Conversation

gordonbondon
Copy link
Contributor

@gordonbondon gordonbondon commented Apr 18, 2019 •
edited
Loading

To remove teams from escalation policy you need to send empty array, but with omitempty it was not possible.

One example where this fix is needed - https://github.com/terraform-providers/terraform-provider-pagerduty/pull/129

@gordonbondon gordonbondon mentioned this pull request Apr 19, 2019
Merged
heimweh
heimweh approved these changes Apr 19, 2019
View reviewed changes
Copy link
Owner

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gordonbondon, thank you so much for this 👍

@heimweh heimweh merged commit 2c0c2f0 into heimweh:master Apr 19, 2019
@gordonbondon gordonbondon deleted the fix-remove-teams branch April 22, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gordonbondon @heimweh