AA-1837 add only_invocable_on_unresolved_incidents option to automation actions #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannagreen1
force-pushed
the
AA-1837
branch
4 times, most recently
from
943706e to
e096acc
Compare
juliannagreen1
force-pushed
the
AA-1837
branch
from
e096acc to
7861975
Compare
|
Hey @heimweh! I have a new addition to the automation action schema. Do you mind taking a look? Thank you! |
imjaroiswebdev
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Hi @juliannagreen1 please address the comments I left, before moving forward with merging. Thank you
| RunnerType *string `json:"runner_type,omitempty"` | ||
| CreationTime *string `json:"creation_time,omitempty"` | ||
| ModifyTime *string `json:"modify_time,omitempty"` | ||
| OnlyInvocableOnUnresolvedIncidents bool `json:"only_invocable_on_unresolved_incidents,omitempty"` |
There was a problem hiding this comment.
@juliannagreen1 please remove the omitempty, otherwise, false value won't be sent/received.
imjaroiswebdev
force-pushed
the
AA-1837
branch
from
6bd0ab3 to
efb96f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new field
only_invocable_on_unresolved_incidentsto Automation Action's schema.