Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports for Automation Actions Action and Runner Update #111

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

mrdubr
Copy link
Contributor

@mrdubr mrdubr commented Dec 21, 2022

Added support for:

New Tests:

make test TESTARGS="-v -run TestAutomationActionsActionUpdate"
==> Testing go-pagerduty
=== RUN   TestAutomationActionsActionUpdate
2022/12/19 16:55:01 ===== PagerDuty Cache Skipping Init =====
--- PASS: TestAutomationActionsActionUpdate (0.00s)
PASS
ok  	github.com/heimweh/go-pagerduty/pagerduty	0.239s
$ make test TESTARGS="-v -run TestAutomationActionsRunnerUpdate"
==> Testing go-pagerduty
=== RUN   TestAutomationActionsRunnerUpdate
2022/12/22 11:37:44 ===== PagerDuty Cache Skipping Init =====
--- PASS: TestAutomationActionsRunnerUpdate (0.00s)
PASS
ok  	github.com/heimweh/go-pagerduty/pagerduty	0.257s

Copy link
Collaborator

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Now with this addition We won't need more to replace action for updates on the Provider 💪🏽

@mrdubr mrdubr force-pushed the a2action_update_support branch from 9607e0f to 116105f Compare December 21, 2022 18:35
@mrdubr mrdubr marked this pull request as draft December 22, 2022 16:36
@mrdubr mrdubr changed the title Add supports for Automation Actions Action Update Add supports for Automation Actions Action and Runner Update Dec 22, 2022
@mrdubr mrdubr marked this pull request as ready for review December 22, 2022 16:38
@mrdubr mrdubr force-pushed the a2action_update_support branch from 5363648 to 16f0e2d Compare January 4, 2023 17:02
Copy link
Collaborator

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌮 🎉

@imjaroiswebdev imjaroiswebdev merged commit 6955a6e into heimweh:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants