Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Refactor id's and data-cy's to underscore #5584

Merged
merged 31 commits into from
Jun 4, 2024
Merged

🧹 Refactor id's and data-cy's to underscore #5584

merged 31 commits into from
Jun 4, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented May 30, 2024 •
edited
Loading

Fixes #5531

How to test
It is quite large so I will check Alpha regularly

  • check if there are typos
  • check a lot of buttons to see if they are still working

Annelein and others added 30 commits May 30, 2024 13:57
@Annelein
all id and data-cy in html to underscore
9623d2f
@Annelein
typescript to underscore
ac00c9a
@Annelein
# to underscore
3c11252
@Annelein
runsovertime
85a50b1
@Annelein @actions-user
🤖 Automatically update generated files
55de53b
@Annelein
Merge branch 'main' into underscore
aead5c6
@Annelein
only opened documents were searched...
08559e6
@Annelein @actions-user
🤖 Automatically update generated files
f8ecbc3
@Annelein
few tests
155f074
@Annelein
few cypress tests
cde0593
@Annelein
Merge branch 'underscore' of https://github.com/hedyorg/hedy into und…
6dd29d1 
…erscore
@Annelein
Merge branch 'main' into underscore
08a2107
@Annelein
Merge branch 'main' into underscore
6827850
@Annelein
more underscores
165fbe6
@Annelein
small mistake
d192e35
@Annelein
fix a few mistakes
2610d9b
@Annelein
cypress test fix
d0b1d54
@Annelein
fixing cypress tests
9e7a7a8
@Annelein
Merge branch 'main' into underscore
ecdc76a
@Annelein @actions-user
🤖 Automatically update generated files
a6b9699
@Annelein
last cypress test fix
25f844c
@Annelein @actions-user
🤖 Automatically update generated files
1bfe330
@Annelein
runs_over_time
0961e28
@Annelein
Merge branch 'underscore' of https://github.com/hedyorg/hedy into und…
4b84464 
…erscore
@Annelein @actions-user
🤖 Automatically update generated files
c8a64d8
@Annelein
user activity buttons to underscore
e395cfb
@Annelein
Merge branch 'underscore' of https://github.com/hedyorg/hedy into und…
d4e4c20 
…erscore
@Annelein
.speaker_controls-
02309af
@Annelein
.speaker_controls-
7467c90
@Annelein
run_over_time
ba2f94e
@Annelein Annelein marked this pull request as ready for review June 4, 2024 12:13
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 4, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1bdb046 into main Jun 4, 2024
12 checks passed
@mergify mergify bot deleted the underscore branch June 4, 2024 12:17
@Annelein Annelein mentioned this pull request Jun 4, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
@Annelein
🧹 Forgotten underscore (#5590)
77505a8 
For PR #5584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felienne Felienne Felienne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hedy organization board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧹 Refactor id's and data-cy's to underscore
2 participants
@Annelein @Felienne