Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 create super teacher #5444

Merged
merged 44 commits into from
Jun 5, 2024
Merged

💻 create super teacher #5444

merged 44 commits into from
Jun 5, 2024

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Apr 22, 2024

Fixes #5443
Fixes #5422
Fixes #5474
Fixes #5371
Fixes #5451

How to test?
First you have to make your teacher account a super teacher. Do so by:

  • logging in as an admin,
  • go to users overview,
  • then mark your account as super teacher.

Test this works expectedly!

Then log in with your super teacher account, now you see Super teacher in the nav bar. With this you can:

  • view feedback submitted by users,
    • if there's no feedback, create one so that you could see it.
    • you should see then all info related to it.
    • you can also click on create issue, which takes opens a new tab with a github issue filled with the selected feedback information.
  • view public adventures
    • and delete any adventure
  • view support teacher page
    • connect one teacher to another (this feature isn't significant for now)
    • what's important is to get a view of teachers who indicated they needed support

DB changes

  • added a is_super_teacher (0 or 1) field to the user table.

@hasan-sh hasan-sh marked this pull request as draft April 23, 2024 13:50
Copy link
Contributor

mergify bot commented Apr 25, 2024

⚠️ The sha of the head commit of this PR conflicts with #5450. Mergify cannot evaluate rules on this PR. ⚠️

@hasan-sh hasan-sh marked this pull request as ready for review May 7, 2024 12:05
@Annelein
Copy link
Collaborator

@hasan-sh I added that it also fixes #5451 right?

@hasan-sh
Copy link
Collaborator Author

@hasan-sh I added that it also fixes #5451 right?

Yes indeed!

@jpelay
Copy link
Member

jpelay commented Jun 4, 2024

Hi! In the PR description it says

what's important is to get a view of teachers who indicated they needed support

But is there a way for a teacher to indicate if they need support? Everything else works, so I would just like to know this in order to approve the PR 😄

@Annelein
Copy link
Collaborator

Annelein commented Jun 5, 2024

There is! But @Felienne do we only want this option when creating an account?
Could it be that they don't know if they need help when signing up, but later on they figure they need help, there is no way to ask for it, right?

Screenshot 2024-06-05 at 10 26 00

@Felienne
Copy link
Member

Felienne commented Jun 5, 2024

There is! But @Felienne do we only want this option when creating an account? Could it be that they don't know if they need help when signing up, but later on they figure they need help, there is no way to ask for it, right?

Screenshot 2024-06-05 at 10 26 00

Not right now, but let's do that separately (and simple, f.e. with a link via email)

@Annelein
Copy link
Collaborator

Annelein commented Jun 5, 2024

Then it's ready @jpelay

@jpelay
Copy link
Member

jpelay commented Jun 5, 2024

There is! But @Felienne do we only want this option when creating an account? Could it be that they don't know if they need help when signing up, but later on they figure they need help, there is no way to ask for it, right?

Screenshot 2024-06-05 at 10 26 00

Thanks didn't notice it!

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Great work!

Copy link
Contributor

mergify bot commented Jun 5, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 37e0a59 into main Jun 5, 2024
12 checks passed
@mergify mergify bot deleted the create-super-teacher branch June 5, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants