Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Show turtle with ask modal #5413

Merged
merged 6 commits into from
Apr 16, 2024
Merged

💻 Show turtle with ask modal #5413

merged 6 commits into from
Apr 16, 2024

Conversation

Annelein
Copy link
Collaborator

Fixes #5396

How to test

  1. Check this code:
repeat 10 times
    forward 100
    hoek is ask 'Hoe ver moet ik draaien?'
    repeat 5 times
        forward 10
        turn hoek
  1. Check if other ask modals and turtle output still looks as it should.
Screen.Recording.2024-04-15.at.14.04.17.mov

Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the ask modal shows, it has the focus. So if I start typing directly and then hit enter, everything works as expected. However, if I get the focus out of the ask modal, I cannot get it back in. So, when the ask modal opens, if I click anywhere on the screen, and then click again on the ask modal (or its Enter button), the modal never becomes active and I cannot type in it.

@Annelein
Copy link
Collaborator Author

@boryanagoncharenko good catch thank you! Pushed a fix

Copy link
Contributor

mergify bot commented Apr 16, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 69ff9d3 into main Apr 16, 2024
12 checks passed
@mergify mergify bot deleted the show-turtle branch April 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 ask with turtle hides turtle screen
2 participants