Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Remove reload for deleting a class and an adventure #5387

Merged
merged 23 commits into from
Apr 17, 2024
Merged

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Apr 9, 2024

Fixes #5383

How to test

  1. Create a class and an adventure
  2. Remove the class and adventure -> the page should not reload and the class/adventure should be removed right away.
  3. Remove an adventure from inside an adventure
Screen.Recording.2024-04-10.at.11.35.02.mov

@Annelein Annelein changed the title 💻 Remove reload for deleting a class and a adventure 💻 Remove reload for deleting a class and an adventure Apr 10, 2024
@Annelein Annelein marked this pull request as ready for review April 15, 2024 09:55
@Annelein Annelein requested a review from hasan-sh April 15, 2024 10:24
@Annelein
Copy link
Collaborator Author

@hasan-sh can you take a look at the failing Cypress tests? I think the code you added cause them

@hasan-sh hasan-sh self-assigned this Apr 16, 2024
Copy link
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 16b795f into main Apr 17, 2024
12 checks passed
@mergify mergify bot deleted the remove-reload branch April 17, 2024 13:05
Copy link
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 removing an adventure causes page reload
2 participants