🚚 Simplify test partitioning #5344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There used to be 3 modes of running the tests:
* Normal
* With `--all` flag (only on non-Weblate PRs)
* With `--weblate` (only on Weblate PRs)
The result was that that the test suites:
tests/test_highlighting
tests/test_level
tests/test_translation_level
Would not be run on Weblate PRs, and not locally.
Simplify the logic a bit by dividing the tests into 2 classes:
- Normal tests, always run
- Slow tests, run on Weblate PRs
Felienne
approved these changes
Apr 1, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There used to be 3 modes of running the tests:
--allflag (only on non-Weblate PRs)--weblate(only on Weblate PRs)The result was that that the test suites:
Would not be run on Weblate PRs, and not locally.
Simplify the logic a bit by dividing the tests into 2 classes: