Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Hangman adventure #5333

Merged
merged 8 commits into from
Apr 10, 2024
Merged

📜 Hangman adventure #5333

merged 8 commits into from
Apr 10, 2024

Conversation

MarleenGilsing
Copy link
Collaborator

@Felienne I've made hangman the same way as the Blackjack adventure and split it up in 3 parts.

There is quite a lot of text, but without it I think it would be too hard to make this code. And it is almost the last level, so this is meant for the students who've made it this far anyway, so they could use a challenge. Could you (or someone else) test it to see if the instructions are clear enough to follow and create a game of hangman (especially part 1 and 2, you don't need to figure out how to draw tha gallow for part 3 haha, unless you feel like it) ?

If it's doable, I will add this adventure to other languages as well and translate it to dutch.

@Felienne
Copy link
Member

Felienne commented Apr 2, 2024

Looks great @MarleenGilsing!! It works a lot better in steps!

A few things:

Step 1

  • We wil have to be precise about how we indicate variable names, now sometimes you do it with quotes ('amount_letters') and sometimes without (game_over). Same for values like False (In the text you do not use quotes but in the text you do.) Shall we use `` , that makes them show like keywords?
  • Do we even want to use 'False' and not False (as in Python) We don't support that now, but I think we should in fact do that!
  • "We want player 1 to be able to choose the choose the answer. " -> choose and choose?

Step 2

  • "*Paste your code " -> Is that * intentional?
  • player 2 -> Do we want to use caps (Player 2)?

Step 3
Perfect, no notes!

@MarleenGilsing MarleenGilsing marked this pull request as ready for review April 4, 2024 09:04
Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

mergify bot commented Apr 9, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Apr 10, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5338aae into main Apr 10, 2024
12 checks passed
@mergify mergify bot deleted the hangman-adventure branch April 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants