Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Add adventure within customize class #5313

Merged
merged 5 commits into from
Mar 27, 2024
Merged

💻 Add adventure within customize class #5313

merged 5 commits into from
Mar 27, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Mar 26, 2024

Fixes #4084

How to test:

  1. Go to /customize-class
  2. Next to the Reset button (top right), click 'Create adventure'.
  3. Check that the Adventure is correctly added to the level and the class you were in.
Screen.Recording.2024-03-27.at.10.12.08.mov

@gisellandrade
Copy link
Collaborator

I'll do it. I didn't start anything about this page, but let me see some references and I'll start working on it.

@hasan-sh
Copy link
Collaborator

hasan-sh commented Mar 26, 2024

I'd add this button next to the reset button, change the color of the reset button to be red and the new create adventure btn to be blue/green. Its current place may not be completely clear to some users and with the bar of adventures, we're hinting to the teachers that this is how it'd look like to students!

@gisellandrade
Copy link
Collaborator

What do you think about this?
image

@gisellandrade
Copy link
Collaborator

We have discussed this in today's meeting and we agreed to place the button next to the reset button because if we place it next to the adventures, the button will move and change its position because it depends on the number of adventures there are. created in the class. So, it would look like this.
image

@Annelein Annelein marked this pull request as ready for review March 27, 2024 09:03
@hasan-sh
Copy link
Collaborator

All good! Shall we remove the create adventure that's in the class overview?

@Annelein
Copy link
Collaborator Author

All good! Shall we remove the create adventure that's in the class overview?

It will be in #5130

Copy link
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3a94a4d into main Mar 27, 2024
12 checks passed
@mergify mergify bot deleted the add-adventure branch March 27, 2024 12:34
Copy link
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI idea] Add adventures from customization page
3 participants