💻 Unsubmit program #5304
Merged
💻 Unsubmit program #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to unsubmit-program
for more information, see https://pre-commit.ci
hasan-sh
requested changes
Mar 26, 2024
for more information, see https://pre-commit.ci
…to unsubmit-program
…to unsubmit-program
for more information, see https://pre-commit.ci
hasan-sh
approved these changes
Mar 27, 2024
| @@ -7,6 +7,11 @@ | |||
| <h2>{{_('submitted_header')}}</h2> | |||
| <h3 class="inline-block mt-0">{{_('submission_time')}}: {{program_timestamp}}</h3> | |||
| </div> | |||
| {% if is_teacher %} | |||
| <div class="text-center"> | |||
| <button class="green-btn" data-cy="unsubmit-btn" onclick="hedyApp.modal.confirm ('{{_('unsubmit_warning')}}', function () {hedyApp.unsubmit_program ('{{initial_adventure.id}}', {{ loop_index }})})">{{_('unsubmit_program')}}</button> | |||
There was a problem hiding this comment.
Suggested change
| <button class="green-btn" data-cy="unsubmit-btn" onclick="hedyApp.modal.confirm ('{{_('unsubmit_warning')}}', function () {hedyApp.unsubmit_program ('{{initial_adventure.id}}', {{ loop_index }})})">{{_('unsubmit_program')}}</button> | |
| <button class="green-btn" data-cy="unsubmit-btn" onclick="hedyApp.unsubmit_program ('{{initial_adventure.id}}', '{{_('unsubmit_warning')}}'))">{{_('unsubmit_program')}}</button> |
Either do this and handle the model in the backend, or convert it to htmx as we usually do!
| @@ -292,12 +292,12 @@ def set_program_public_by_id(self, id, public): | |||
| """ | |||
| return PROGRAMS.update({"id": id}, {"public": 1 if public else 0}) | |||
|
|
|||
| def submit_program_by_id(self, id): | |||
| def submit_program_by_id(self, id, submit): | |||
There was a problem hiding this comment.
Perhaps change the name of the fuction to reflect what it's really doing?
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4634
How to test:
Screen.Recording.2024-03-25.at.12.24.39.mov