Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Address TODOs in hedy.py #5259

Merged
merged 7 commits into from
Mar 15, 2024
Merged

🧹 Address TODOs in hedy.py #5259

merged 7 commits into from
Mar 15, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

Fixes #1632
Issue #1632 was open to handle all TODOs in the file hedy.py, since they were piling. This PR addresses some of the easy TODOs which do not require massive changes. Every refactoring is done in a separate commit. The remaining TODOs should have their dedicated issues.

How to test

  • All of the code parts which are refactored are covered with automated tests

@jpelay jpelay self-assigned this Mar 15, 2024
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bc60328 into main Mar 15, 2024
12 checks passed
@mergify mergify bot deleted the duplication_todo_1632 branch March 15, 2024 18:08
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Clean-up TODOs in hedy.py
3 participants