🖊️ Add user-friendly errors for calculations with incorrect types #3465 #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boryanagoncharenko
force-pushed
the
runtime_error_messages_3465
branch
7 times, most recently
from
00dac5b
to
ed3f4b5
Compare
boryanagoncharenko
force-pushed
the
runtime_error_messages_3465
branch
from
66cd199
to
7bc7454
Compare
jpelay
approved these changes
Mar 12, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
boryanagoncharenko
added a commit
that referenced
this pull request
Mar 13, 2024
… (#5226) Fixes #3465 Add custom error message when calculations are passed incompatible types. **How to test** - All automated tests should pass - Run Hedy locally and navigate to specified level. Run the following code and supply a string instead of a number. Ensure that there is a nice error displayed and no python error leaks: Level 6 ``` hoeken = ask 'Hoeveel hoeken krijgt dit figuur?' hoek = 360 / hoeken print hoek ``` Level 12 ``` hoeken = ask 'Hoeveel hoeken krijgt dit figuur?' hoek = 360 / hoeken print hoek ``` Level 12. Note that addition should show a different error since concatenation works from level 12. ``` hoeken = ask 'Hoeveel hoeken krijgt dit figuur?' hoek = 360 + hoeken print hoek ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3465
Add custom error message when calculations are passed incompatible types.
How to test
Level 6
Level 12
Level 12. Note that addition should show a different error since concatenation works from level 12.