-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Refactor Pygame Code #5117
🧹 Refactor Pygame Code #5117
Conversation
- only for level 5
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ode' of https://github.com/hedyorg/hedy into 3966-chore-remove-superflous-code-in-generated-pygame-code
…cy has been removed for the feature
for more information, see https://pre-commit.ci
Hi @jpelay and @ToniSkulj! I have updates all level tests, except for one that I did not know how to deal with (I commented that out in 0061806) I am not sure if more it needed at the moment, so I will leave this to you two for now! |
…ode' of https://github.com/hedyorg/hedy into 3966-chore-remove-superflous-code-in-generated-pygame-code
Hi @Felienne! The only case that remains is when the user uses elifs without an else. Currently, it does not do anything. |
Awesome, thanks so much for seeing this through! If you have an idea for the elif/else issue, do keep us posted. Otherwise we can always throw an exception and say: you can't use elif in pressed without else. |
Also remove unnecessary variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a great work!!! Thank you SO MUCH for this! This is a great PR and everything worked, but a couple of things that I fixed myself.
There's an issue still with the debugger, but there's an issue opened fort that already on #4765!
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
PR for removing the use of Pygame within Hedy.
We still want to keep the functionality of "if button pressed".