Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Refactor Pygame Code #5117

Merged

Conversation

ToniSkulj
Copy link
Member

PR for removing the use of Pygame within Hedy.
We still want to keep the functionality of "if button pressed".

@ToniSkulj ToniSkulj linked an issue Feb 9, 2024 that may be closed by this pull request
@ghost
Copy link

ghost commented Feb 9, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne
Copy link
Member

Hi @jpelay and @ToniSkulj!

I have updates all level tests, except for one that I did not know how to deal with (I commented that out in 0061806)

I am not sure if more it needed at the moment, so I will leave this to you two for now!

@ToniSkulj
Copy link
Member Author

Hi @Felienne!
Thank you for adding the tests! I fixed the level 8 test, all tests should be passing now.

The only case that remains is when the user uses elifs without an else. Currently, it does not do anything.
I will keep you updated when I find something to solve that.

@Felienne
Copy link
Member

Hi @Felienne! Thank you for adding the tests! I fixed the level 8 test, all tests should be passing now.

The only case that remains is when the user uses elifs without an else. Currently, it does not do anything. I will keep you updated when I find something to solve that.

Awesome, thanks so much for seeing this through! If you have an idea for the elif/else issue, do keep us posted. Otherwise we can always throw an exception and say: you can't use elif in pressed without else.

@jpelay jpelay marked this pull request as ready for review March 26, 2024 22:55
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great work!!! Thank you SO MUCH for this! This is a great PR and everything worked, but a couple of things that I fixed myself.

There's an issue still with the debugger, but there's an issue opened fort that already on #4765!

Copy link
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5494e07 into main Mar 27, 2024
12 checks passed
@mergify mergify bot deleted the 3966-chore-remove-superflous-code-in-generated-pygame-code branch March 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[CHORE] Remove superflous code in generated PyGame code
3 participants