[LANG] No warning for unused function

[Felienne]

Fixes #4911. Turns out, there were a few open issues in the unused variable warning! Calculations were not properly caught, and built-in names (like sum) were not detected. This fixes all open issues (I hope!)

How to test

I added a few new tests

[ghost]

👇 Click on the image for a new way to code review

Legend

[jpelay]

It does indeed solve the issue! Now, while testing, I found that you can use a function that you have not defined inside a calculation:

When you just call it, it returns a Python error:

Maybe we can solve this in this PR? What do you think=

[Felienne]

Ah good catch! I would prefer to do it in a separate PR because this PR already has quite some changes all over hedy.py so I suspect it can lead to conflicts? Can you make an issue? Thanks!!

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

[jpelay]

Ah good catch! I would prefer to do it in a separate PR because this PR already has quite some changes all over hedy.py so I suspect it can lead to conflicts? Can you make an issue? Thanks!!

Opened #4921! 😄

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).