-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LANGUAGE] Convert calc to int in sleep level 12 #4677
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hi @ToniSkulj! This change to the handling of sleep messes up one of your tests :( (see: 6e57009) I have disabled it for now (since I don't exactly understand why it fails, it does not seem to see an inner error production?) Would be great if you can take a look, either in this PR or in a fresh one. Thanks! |
Hi @Felienne! Of course! bc2ec53 fixes the test in level 16. Essentially what happens is that when skipping error_list_access_at the transpiling is accidentally still correct. |
Hi @Felienne! It all works great, but since we are allowing float variables to be used with sleep, we probably want float literals to be allowed to |
Ah great catch, should be easy to allow. I will add that too in this PR! |
Should be ready to go now @jpelay! |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #4672
This PR does three things to improve weird error messages.
Firstly, it escapes the library name time, fixing error number three named in #4672:
It also converts sleep input to integers, so that you can use fractions (error number 1):
And it allows floats as input for sleep in level 12 and up, fixing error 2:
How to test
I added tests for all cases