[LANGUAGE] improved error productions for at #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… | messages.po | level3-Additions.lark
for more information, see https://pre-commit.ci
Felienne
reviewed
Oct 24, 2023
no code changes, only some thought process in notes at corresponding locations
…nto error-productions
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…tion is erroneous
…nto error-productions
the todo is met in case an error such as the following is made: animals is dog, cat, kangaroo print animals at indec index is not an existing variable which leads to the else statement in check_var_usage
there seems to be alot of files changed on translations, I am not sure whether this is expected behavior as it seems to have changed translations besides my own.
Felienne
reviewed
Nov 21, 2023
Felienne
reviewed
Nov 21, 2023
Felienne
reviewed
Nov 21, 2023
|
Hi @akseron! This can be merged if you update the PR description (the first message here) to describe briefly what you did and why (and whether there is an open issue related to this PR) |
Felienne
requested changes
Nov 21, 2023
Felienne
reviewed
Nov 21, 2023
Felienne
reviewed
Nov 21, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Felienne
approved these changes
Nov 21, 2023
|
And congrats on getting your first contribution accepted @akseron! It was quite a ride, but you did it!! |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in error production in level 4 lark file and check_var_usage in main hedy file to support better syntax error messages for the 'at' command.
Fixes #4780