Add RecheckInfo to simplify recheck reporting #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I can do better by splitting the |
TysonMN
force-pushed
the
recheck_reporting
branch
from
0222b38 to
479c4c4
Compare
|
Yes, much better |
dharmaturtle
reviewed
Dec 5, 2021
|
I pushed a commit with improvements based on your comments @dharmaturtle. (I will squash to one commit before merging.) |
dharmaturtle
reviewed
Dec 6, 2021
TysonMN
force-pushed
the
recheck_reporting
branch
from
cac34c4 to
cca9fd2
Compare
TysonMN
force-pushed
the
recheck_reporting
branch
from
cca9fd2 to
45d0f00
Compare
TysonMN
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This really isn't an improvement on its own, but this will simplify PR #336.
reportWith'currently populatesOutcome.Failure.Statuswith the return value from a call toshrinkInput. With the optimized rechecking in PR #336, no shrinking occurs when rechecking. Instead,Outcome.Failure.Statusis populated after following the shrink path with an instance ofStatus.Failedthat doesn't need to provide recheck data.