Pad the cache update buffer to 256 bytes so that textures display in Chrome Canary #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks! Does this limitation only apply to Chrome Canary? In that case, it may be a good idea to enable the new code only when targetting Wasm. |
dhardy
reviewed
May 25, 2020
Comment on lines
+7
to
+11
| if value % 256 == 0 { | ||
| value | ||
| } else { | ||
| (value / 256 + 1) * 256 | ||
| } |
There was a problem hiding this comment.
This simplifies to ((value + 255) / 256) * 256.
|
This restriction has now been implemented in wgpu, so it should be always enabled. (its part of the webgpu spec) You might find this change to the capture example useful to refer to https://github.com/gfx-rs/wgpu-rs/pull/348/files |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that gfx-rs/wgpu-rs#193 has landed, it'd be great to get wgpu_glyph to work in-browser! At the moment, the only browser that WebGPU works okay-ish on is Chrome Canary.
Chrome Canary has a stricter implementation of WebGPU than wgpu, and requires that all textures have a row pitch that is a multiple of 256 bytes. This PR checks the width of the data that the cache is updated with, and allocated a new vector with the correct padding if the width is not a multiple of 256.