Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing translation for rosh hashana #10

Closed
ilayDev opened this issue Sep 14, 2020 · 2 comments
Closed

missing translation for rosh hashana #10

ilayDev opened this issue Sep 14, 2020 · 2 comments
Assignees

Comments

@ilayDev
Copy link

ilayDev commented Sep 14, 2020

the render function on Rosh Hashana event always returns the English string even when the locale parameter is set to 'he' or 'fr'
it's works fine for Rosh Hashana day 2 but not for day 1

for example:
events /*
[
HolidayEvent {
date: HDate { month: 7, day: 1, year: 5781 },
desc: 'Rosh Hashana 5781',
mask: 33,
attrs: [Object: null prototype] {}
},
HolidayEvent {
date: HDate { month: 7, day: 2, year: 5781 },
desc: 'Rosh Hashana II',
mask: 5,
attrs: [Object: null prototype] {}
}
] */

var translateToHebrew = events.map(ev=>ev.render('he') ); //[ 'Rosh Hashana 5781', 'רֹאשׁ הַשָּׁנָה יוֹם ב׳' ]

@mjradwin mjradwin self-assigned this Sep 14, 2020
@mjradwin
Copy link
Member

Confirmed. We'll work on a fix.

@mjradwin
Copy link
Member

Fixed in @hebcal/core@2.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants