Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1 #1821

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Rails 7.1 #1821

merged 4 commits into from
Oct 11, 2023

Conversation

carlosantoniodasilva
Copy link
Member

No description provided.

Update MiniTest => Minitest constant reference.

`rails-dom-testing` changed the `NO_STRIP` constant around, update the
code that references it via `ActionDispatch::Assertions` (because it was
included there) to point to the lib directly, making it more explicit.
@carlosantoniodasilva carlosantoniodasilva self-assigned this Oct 10, 2023
Rails 7.1 is deprecating the `ActiveSupport::Deprecation.instance` usage
in favor of defining library-specific deprecators, this implements one
for SimpleForm going forward.
@carlosantoniodasilva carlosantoniodasilva marked this pull request as ready for review October 11, 2023 11:14
@carlosantoniodasilva carlosantoniodasilva merged commit bf1013a into main Oct 11, 2023
@carlosantoniodasilva carlosantoniodasilva deleted the ca/rails-71 branch October 11, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant