Respond form submission errors with 422 status code

[santib]

Seems like Rails new convention will be returning 422 on form submission errors rails/rails#41026 . It'd be a good idea to wait and see if that Rails PR is merged thus making official the new "convention". The root reason behind the change is supporting Turbo.

More info:

• Render 400-500 status response HTML hotwired/turbo#39
• Error: Form responses must redirect to another location hotwired/turbo#22 (comment)

[carlosantoniodasilva]

Thanks. I think this change actually needs to happen in responders to be the default behavior heartcombo/responders#159, and Devise will follow.

I want to give it a little more time to settle in and for me to review turbo as well, before doing any change since it will require at least a minor (or major) bump.

[santib]

@carlosantoniodasilva Just a heads up that the Rails PR got merged. Not sure if you still want to wait some more time, if want to close this PR and continue it on the responders gem or what is the correct course of action here.

[carlosantoniodasilva]

@santib thanks, I'm working on this on the responders side of things, but I'm gonna leave this open for a bit longer since I also need to ensure Devise works with it fine. (and note the behavior change in the changelog, etc.)

[carlosantoniodasilva]

FYI: I have a working branch in Responders that should change this behavior to return 422 similarly: heartcombo/responders#223. Any feedback there is welcome.

[gobijan]

I think this PR should be closed and the responders gem should be updated. Devise should then use the updated responders gem and things should be good to go. Just had a brief look at devise tests. 422 cases should get added to the tests then.

[carlosantoniodasilva]

Thanks @gobijan, I'm gonna close it when I get responders released and Devise updated here. (this is sorta working as a reminder for me 😁)

[ghiculescu]

@santib do you want to give #5340 a try? This is required for SessionsController. All other controllers are fixed by heartcombo/responders#223

[carlosantoniodasilva]

Closing in favor of #5340, thanks!