Test on rails 6.1 #5323
Merged
Test on rails 6.1 #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ActiveModel::Errors` has been changed in Rails 6.1. rails/rails#32313
tricknotes
force-pushed
the
test-on-rails-6.1
branch
from
c20946b to
3b30209
Compare
a-baqtyan
reviewed
Jan 2, 2021
| @@ -30,12 +30,12 @@ class AuthenticatableTest < ActiveSupport::TestCase | |||
|
|
|||
| test 'find_or_initialize_with_errors adds blank error' do | |||
| user_with_error = User.find_or_initialize_with_errors([:email], { email: "" }) | |||
| assert_equal [:email, "can't be blank"], user_with_error.errors.first | |||
| assert_equal ["Email can't be blank"], user_with_error.errors.full_messages_for(:email) | |||
There was a problem hiding this comment.
assert_equal ['Email can't be blank'], user_with_error.errors.full_messages_for(:email)
Use single quotations
There was a problem hiding this comment.
This string contains ', so we should escape it as back slash in the single quotations.
Therefore, using " makes it readable.
Why do you think so?
There was a problem hiding this comment.
Double quotes is fine here, thanks.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 6.1 has been released.
https://edgeguides.rubyonrails.org/6_1_release_notes.html
This PR added CI matrix for Rails 6.1.