Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update password confirmation autocomplete #5054

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Update password confirmation autocomplete #5054

merged 1 commit into from
Apr 3, 2019

Conversation

ferrl
Copy link

@ferrl ferrl commented Apr 2, 2019

Update password_confirmation fields to include the correct autocomplete parameter, based on the discussions here and here.

feliperenan
feliperenan approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@feliperenan feliperenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@ferrl ferrl merged commit c1e4031 into heartcombo:master Apr 3, 2019
jasl added a commit to jasl/cybros_core that referenced this pull request May 9, 2019
@jasl
port heartcombo/devise#5054
66932ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feliperenan feliperenan feliperenan approved these changes

@saiqulhaq saiqulhaq saiqulhaq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferrl @saiqulhaq @feliperenan