Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update healpix-cxx to 3.60 #589

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Dec 1, 2019

Fixes #576.

This should work but for the two issues mentioned in #576 that must first be fixed in the HEALPix svn repository.

@lpsinger
Copy link
Member Author

lpsinger commented Dec 3, 2019

@mreineck, the build is failing with this error message:

In file included from healpy/src/_sphtools.cpp:635:0:
1675/home/travis/build/healpy/healpy/build/temp.linux-x86_64-2.7/include/healpix_cxx/weight_utils.h:71:10: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
1676     std::unique_ptr<weight_utils_detail::FullWeightImpl> impl;
1677          ^
1678

Do we need to build with -std=c++11?

@mreineck
Copy link
Member

mreineck commented Dec 3, 2019

Do we need to build with -std=c++11?

Yes, that will be necessary.

@lpsinger
Copy link
Member Author

lpsinger commented Dec 3, 2019

@zonca, the build is now passing. This is ready for review.

@zonca
Copy link
Member

zonca commented Dec 3, 2019

thanks @lpsinger for making this work!

@zonca zonca merged commit 071089a into healpy:master Dec 3, 2019
@zonca zonca mentioned this pull request Dec 3, 2019
@lpsinger lpsinger deleted the healpix-cxx-3.60 branch December 3, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface to HEALPix 3.60
3 participants