-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix bad link in plugin dev docs #2256
Conversation
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
FWIW, I am stuck, trying to build a plugin locally or in a dockerfile results in a failure. Lots of ModuleNotFound errors:
I am on a NodeJS 20 runtime locally, NodeJS 18 in the dockerfile (adapted from the example, that uses NodeJS 16) - I think the result is the same on either one. I can try with a simpler plugin to start, but if someone is available to talk me through it - or if a more recent walkthrough of plugin building is already published somewhere, I'd be very appreciative of a link! |
@kingdonb Thanks. For testing a plugin, the fastest way is just to have it locally and test it with the desktop app. This involves having the plugin repo cloned, then running |
Sorry for the obvious question, but did you run |
I can't run it locally, I am setting up a collaborative environment for me, @stefanprodan, and @ashu8912 - it has to run in the cluster. No, I didn't run I was going by the Dockerfile in the blog, we should update the blog so it works! :) |
following those steps, including npm start I was able to get the plugin building for production locally at least. I'll bang on it a bit longer until I figure out what's missing from the blog, there are only a few places where "npm install" could go so maybe it will be an easy fix |
I landed on:
I think there's a better formula because it seems like you will need to run npm install for each plugin this way, but my skepticism about if this would even work seems to have been overblown, I was expecting the resulting image to be hundreds of megabytes, and it's only 10.8MB 👍 Will spend a bit more time testing this and see what I can come up with. Next step for now is to push the image somewhere and see if I can get this running in the cluster. |
FWIW, now that our |
Macbook with Apple Silicon built the plugin image and the cluster is x86_64, so that was another obstacle I had to quickly overcome, an
Now it's running in the cluster, the rest of the details in the blog post were fine. (Leaving this breadcrumb for anyone who is currently following along, between now and whenever we are able to update + fix the blog post with those missing details.) I will go back down the stack and start nailing these things down in my fork, add some declarative artifacts, GHA workflows, so we can reproduce this easily in the future and iterate development until everyone agrees we can release this plugin (ref: #1872) - note the canary image is NOT intended to be used for production 😅 (is there a process for installing plugins in production that I missed, or is it click-driven, as they go into a persistent volume?) This might have something to do with the artifacthub note you just mentioned - I would expect to be able to make a list of plugins to preinstall in the helm values, but maybe that is not how it's intended to work. Are end users expected to install a collection of plugins from a named maintainer, or manage their own plugins image? Maybe there are multiple intended paths, (mainly depending I guess on whether you have someone on the payroll developing a plugin in your organization, or not) I am working through the authentication docs now, generate a service account token first, configure for OIDC with Dex next - I'm hopeful that it worked, because it is in fact running now 🎉 |
Will continue the discussion in #1872 |
This is a broken reference in the docs.
(Can anyone let me know if this doc is outdated before I invest a bunch of time and find out it doesn't work?)
I won't hold this PR up by marking it as a draft, because the link is definitely broken, but if the doc is outdated and that's why the reference is bad, then maybe we shouldn't merge it. (I'll get around to building headlamp today with flux plugin that's in development, if the documents are good, but ...)