Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rule for testing hardware designs using Cocotb framework #170

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

rw1nkler
Copy link
Contributor

@rw1nkler rw1nkler commented Jul 4, 2023

This PR adds the cocotb_test rule which may be used to test hardware designs using Cocotb framework. The created rule uses a simple Python script that filters arguments and passes them to the Cocotb Runner. Most of the arguments of the cocotb_test rule are passed directly to the runner. Besides that, a simple test with a counter has been added to test the created rule.

@rw1nkler rw1nkler force-pushed the 45029-cocotb branch 4 times, most recently from d97d616 to 7e2295f Compare July 5, 2023 11:54
@rw1nkler rw1nkler marked this pull request as draft July 5, 2023 12:49
@QuantamHD
Copy link
Collaborator

Really cool stuff! I love it. Just a few comments.

cocotb/cocotb.bzl Outdated Show resolved Hide resolved
cocotb/BUILD Outdated Show resolved Hide resolved
cocotb/cocotb.bzl Show resolved Hide resolved
@QuantamHD
Copy link
Collaborator

I'll merge once the CI passes, and you unmark this as "Draft"

rw1nkler added 3 commits July 5, 2023 22:33
This commit adds cocotb_test() rule which may be used to test HDL sources
using Cocotb framework.

Internal-tag: [#45029]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#45029]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
This change allows other utility scripts to interact with iverilog and vvp
by adding them to the PATH as find may not find them.
This happens when iverilog or vvp are used as tools of other rules

Internal-tag: [#45029]
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler
Copy link
Contributor Author

rw1nkler commented Jul 5, 2023

I squashed the review commits and marked the PR as "Ready for review"

@rw1nkler rw1nkler marked this pull request as ready for review July 5, 2023 20:35
@rw1nkler rw1nkler requested a review from QuantamHD July 5, 2023 20:52
@QuantamHD QuantamHD merged commit f0cf7cf into hdl:main Jul 5, 2023
@rw1nkler rw1nkler deleted the 45029-cocotb branch July 14, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants