Only accept LF (linux style) end of lines #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the rule to checkstyle configuration and fix files that need fixing.
|
@maxgabut you'll have to rebase this because of changes made in a PR I made that got accepted which are causing conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently multiple style of line ending in the project.
As suggested in #564, I think that there should be only one style in the code base.
In this PR I added a checkstyle rule to only allow linux style end of line and I changed the files that had different style.
review note: the diff is quite heavy, but ignoring whitespace changes will remove all changes except the checkstyle rule.
@hcoles WDYT ?