Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preview media attachments #5102

Merged

Conversation

chemarbraithwaite
Copy link
Contributor

@chemarbraithwaite chemarbraithwaite commented Mar 30, 2024

Contribution checklist

Brief description

Show a preview for supported media (eg. videos, and audio) on click, instead of downloading the file.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-6235

Chemar Braithwaite added 2 commits March 30, 2024 10:52
Signed-off-by: Chemar Braithwaite <chemarbraithwaite@Chemars-MacBook-Pro.local>
Signed-off-by: Chemar Braithwaite <chemarbraithwaite@Chemars-MacBook-Pro.local>
@haiodo haiodo requested review from aonnikov and haiodo April 1, 2024 04:43
@haiodo haiodo merged commit f99998f into hcengineering:main Apr 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants