Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): new layout for attached todos #4995

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

euaaaio
Copy link
Contributor

@euaaaio euaaaio commented Mar 15, 2024

Contribution checklist

Brief description

Screencast

Screen.Recording.2024-03-15.at.19.33.32.mov

Important changes

  • Changed the logic of creating todo from the issue. Before, we used issue identifier as title. Now we copy the title of issue in the todo as it is, since we get issue identifier from special presenter.
  • Refactored navigation of attached objects. Before, we had a bug with the page changing after reloading. Now we have a valid url for each opened object.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

View in Huly UBERF-6049

@euaaaio euaaaio force-pushed the feat/planner-new-attached-todo-layout branch from 5ccec8d to eb76e48 Compare March 17, 2024 15:14
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio euaaaio force-pushed the feat/planner-new-attached-todo-layout branch from eb76e48 to 1d297a8 Compare March 18, 2024 08:25
@euaaaio euaaaio marked this pull request as ready for review March 18, 2024 08:43
euaaaio added 3 commits March 18, 2024 15:07
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@euaaaio
Copy link
Contributor Author

euaaaio commented Mar 18, 2024

Pushed changes:

  • Used modern layout for Panel in EditDoc
  • Visually, nothing else has changed
  • Added ToDoReference to reduce repeated code
  • Removed issue status editor in IssuePresenter since it is not used anywhere yet. There is no longer any use for it in the design, and we don't need such a heavy nesting of invisible buttons.
  • Removed and added some unused props to prevent Svelte warnings. They will be used in future updates for planner calendar and team planning.

Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
@kristina-fefelova kristina-fefelova merged commit c9761b3 into main Mar 18, 2024
7 checks passed
@kristina-fefelova kristina-fefelova deleted the feat/planner-new-attached-todo-layout branch March 18, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants