Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-1668: Side changes from Surveys #4271

Merged
merged 17 commits into from
Dec 26, 2023
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* [ ] - UI test added to added/changed functionality?
* [ ] - Screenshot is added to PR if applicable ?
* [ ] - Does a local formatting is applied (rush format)
* [ ] - Does a local svele-check is applied (rush svelte check)
* [ ] - Does a local svele-check is applied (rush svelte-check)
* [ ] - Does a local UI tests are executed [UI Testing](../tests/readme.md)
* [ ] - Does the code work? Check whether function and logic are correct.
* [ ] - Does Changelog.md is updated with changes?
Expand Down
155 changes: 8 additions & 147 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions dev/prod/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,6 @@
"@hcengineering/support": "^0.6.1",
"@hcengineering/support-assets": "^0.6.1",
"@hcengineering/support-resources": "^0.6.0",
"@hcengineering/survey": "^0.6.0",
"@hcengineering/survey-assets": "^0.6.0",
"@hcengineering/survey-resources": "^0.6.0",
"@hcengineering/request": "^0.6.6",
"@hcengineering/request-assets": "^0.6.0",
"@hcengineering/request-resources": "^0.6.0",
Expand Down
4 changes: 0 additions & 4 deletions dev/prod/src/platform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import rekoni from '@hcengineering/rekoni'
import { requestId } from '@hcengineering/request'
import { settingId } from '@hcengineering/setting'
import { supportId } from '@hcengineering/support'
import { surveyId } from '@hcengineering/survey'
import { tagsId } from '@hcengineering/tags'
import { taskId } from '@hcengineering/task'
import telegram, { telegramId } from '@hcengineering/telegram'
Expand Down Expand Up @@ -64,7 +63,6 @@ import '@hcengineering/recruit-assets'
import '@hcengineering/request-assets'
import '@hcengineering/setting-assets'
import '@hcengineering/support-assets'
import '@hcengineering/survey-assets'
import '@hcengineering/tags-assets'
import '@hcengineering/task-assets'
import '@hcengineering/telegram-assets'
Expand Down Expand Up @@ -123,7 +121,6 @@ function configureI18n(): void {
addStringsLoader(requestId, async (lang: string) => await import(`@hcengineering/request-assets/lang/${lang}.json`))
addStringsLoader(settingId, async (lang: string) => await import(`@hcengineering/setting-assets/lang/${lang}.json`))
addStringsLoader(supportId, async (lang: string) => await import(`@hcengineering/support-assets/lang/${lang}.json`))
addStringsLoader(surveyId, async (lang: string) => await import(`@hcengineering/survey-assets/lang/${lang}.json`))
addStringsLoader(tagsId, async (lang: string) => await import(`@hcengineering/tags-assets/lang/${lang}.json`))
addStringsLoader(taskId, async (lang: string) => await import(`@hcengineering/task-assets/lang/${lang}.json`))
addStringsLoader(telegramId, async (lang: string) => await import(`@hcengineering/telegram-assets/lang/${lang}.json`))
Expand Down Expand Up @@ -200,7 +197,6 @@ export async function configurePlatform() {
addLocation(bitrixId, () => import(/* webpackChunkName: "bitrix" */ '@hcengineering/bitrix-resources'))
addLocation(requestId, () => import(/* webpackChunkName: "request" */ '@hcengineering/request-resources'))
addLocation(supportId, () => import(/* webpackChunkName: "support" */ '@hcengineering/support-resources'))
addLocation(surveyId, () => import(/* webpackChunkName: "support" */ '@hcengineering/survey-resources'))

setMetadata(client.metadata.FilterModel, true)
setMetadata(client.metadata.ExtraPlugins, ['preference' as Plugin])
Expand Down
6 changes: 3 additions & 3 deletions dev/tool/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function devTool (

program.version('0.0.1')

// create-user john.appleseed@gmail.com --password 123 --workspace workspace --fullname "John Appleseed"
// create-account john.appleseed@gmail.com --password 123 --workspace workspace --fullname "John Appleseed"
program
.command('create-account <email>')
.description('create user and corresponding account in master database')
Expand Down Expand Up @@ -476,7 +476,7 @@ export function devTool (

program
.command('clean-workspace <workspace>')
.description('set user role')
.description('clean workspace')
.option('--recruit', 'Clean recruit', false)
.option('--tracker', 'Clean tracker', false)
.option('--removedTx', 'Clean removed transactions', false)
Expand All @@ -501,7 +501,7 @@ export function devTool (

program
.command('clean-removed-transactions <workspace>')
.description('set user role')
.description('clean removed transactions')
.action(async (workspace: string, cmd: any) => {
await cleanRemovedTransactions(getWorkspaceId(workspace, productId), transactorUrl)
})
Expand Down
3 changes: 1 addition & 2 deletions models/all/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
"@hcengineering/model-server-activity": "^0.6.0",
"@hcengineering/model-server-openai": "^0.6.0",
"@hcengineering/model-server-translate": "^0.6.0",
"@hcengineering/model-support": "^0.6.0",
"@hcengineering/model-survey": "^0.6.0"
"@hcengineering/model-support": "^0.6.0"
}
}
16 changes: 2 additions & 14 deletions models/all/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ import { taskId, createModel as taskModel } from '@hcengineering/model-task'
import telegram, { telegramId, createModel as telegramModel } from '@hcengineering/model-telegram'
import { templatesId, createModel as templatesModel } from '@hcengineering/model-templates'
import { textEditorId, createModel as textEditorModel } from '@hcengineering/model-text-editor'
import survey, { surveyId, createModel as surveyModel } from '@hcengineering/model-survey'
import tracker, { trackerId, createModel as trackerModel } from '@hcengineering/model-tracker'
import view, { viewId, createModel as viewModel } from '@hcengineering/model-view'
import workbench, { workbenchId, createModel as workbenchModel } from '@hcengineering/model-workbench'
Expand Down Expand Up @@ -254,25 +253,14 @@ export default function buildModel (enabled: string[] = ['*'], disabled: string[
requestModel,
requestId,
{
label: survey.string.ConfigLabel,
description: survey.string.ConfigDescription,
// request: request.string.ConfigLabel,
// request: request.string.ConfigDescription,
enabled: false,
beta: true,
icon: survey.icon.SurveyApplication,
classFilter: defaultFilter
}
],
[supportModel, supportId],
[
surveyModel,
surveyId,
{
// TODO: icon, label, description?
enabled: true,
beta: true,
classFilter: defaultFilter
}
],

[serverCoreModel, serverCoreId],
[serverAttachmentModel, serverAttachmentId],
Expand Down
4 changes: 2 additions & 2 deletions models/bitrix/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import bitrix from '@hcengineering/bitrix-resources/src/plugin'
import { type IntlString, mergeIds } from '@hcengineering/platform'
import { type Action } from '@hcengineering/view'

import { type Ref } from '@hcengineering/core'
import { type Doc, type Ref } from '@hcengineering/core'
import type { AnyComponent } from '@hcengineering/ui/src/types'

export default mergeIds(bitrixId, bitrix, {
Expand All @@ -34,6 +34,6 @@ export default mergeIds(bitrixId, bitrix, {
ConfigDescription: '' as IntlString
},
action: {
BitrixImport: '' as Ref<Action>
BitrixImport: '' as Ref<Action<Doc, any>>
}
})
6 changes: 3 additions & 3 deletions models/chunter/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ export default mergeIds(chunterId, chunter, {
ArchiveChannel: '' as Ref<Action>,
UnarchiveChannel: '' as Ref<Action>,
ConvertToPrivate: '' as Ref<Action>,
CopyCommentLink: '' as Ref<Action>,
CopyThreadMessageLink: '' as Ref<Action>,
CopyMessageLink: '' as Ref<Action>
CopyCommentLink: '' as Ref<Action<Doc, any>>,
CopyThreadMessageLink: '' as Ref<Action<Doc, any>>,
CopyMessageLink: '' as Ref<Action<Doc, any>>
},
actionImpl: {
MarkUnread: '' as ViewAction,
Expand Down
2 changes: 1 addition & 1 deletion models/contact/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export default mergeIds(contactId, contact, {
action: {
KickEmployee: '' as Ref<Action>,
DeleteEmployee: '' as Ref<Action>,
MergePersons: '' as Ref<Action>
MergePersons: '' as Ref<Action<Doc, any>>
},
actionImpl: {
KickEmployee: '' as ViewAction,
Expand Down
2 changes: 1 addition & 1 deletion models/gmail/src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { type NotificationGroup } from '@hcengineering/notification'

export default mergeIds(gmailId, gmail, {
action: {
WriteEmail: '' as Ref<Action>
WriteEmail: '' as Ref<Action<Doc, any>>
},
string: {
MessageID: '' as IntlString,
Expand Down
Loading