Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBER-851: fix titles in ListView #3678

Merged
merged 2 commits into from
Sep 11, 2023
Merged

UBER-851: fix titles in ListView #3678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1137685
UBER-851: fix titles in ListView
SasLord Sep 11, 2023
513089e
Fix UI test
SasLord Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/presentation/src/components/NavLink.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@
<style lang="scss">
span,
a {
display: flex;
align-items: center;
min-width: 0;
font-weight: inherit;

Expand Down
1 change: 0 additions & 1 deletion packages/theme/styles/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,6 @@
border-radius: 1.625rem;
transition: flex-shrink 0.25s cubic-bezier(0.38, 0.01, 0.33, 1) 0s;

&:not(:empty) { min-width: 7.5rem; }
&:hover {
flex-shrink: .5;
min-width: initial;
Expand Down
8 changes: 5 additions & 3 deletions plugins/tracker-resources/src/components/issues/ParentNamesPresenter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
{#each value.parents as parentInfo}
<!-- svelte-ignore a11y-click-events-have-key-events -->
<span
class="name overflow-label cursor-pointer"
class="parent-label overflow-label cursor-pointer"
title={parentInfo.parentTitle}
on:click={() => handleIssueEditorOpened(parentInfo)}
>
Expand All @@ -46,7 +46,7 @@

<style lang="scss">
.root {
display: flex;
display: inline-flex;
margin-left: 0;
min-width: 0;

Expand All @@ -56,7 +56,9 @@
color: var(--theme-dark-color);
}

.name {
.parent-label {
flex-shrink: 5;

&:hover {
color: var(--theme-caption-color);
text-decoration: underline;
Expand Down
17 changes: 6 additions & 11 deletions plugins/tracker-resources/src/components/issues/TitlePresenter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,13 @@

{#if value}
<span
class="name overflow-label select-text"
class="presenter-label select-text"
class:with-margin={shouldUseMargin}
class:list={kind === 'list'}
style:max-width={maxWidth}
title={value.title}
>
<DocNavLink
object={value}
{disabled}
{onClick}
component={tracker.component.EditIssue}
inline
shrink={1}
colorInherit
>
<DocNavLink object={value} {onClick} component={tracker.component.EditIssue} shrink={1} colorInherit>
{value.title}
</DocNavLink>
</span>
Expand All @@ -55,7 +47,10 @@
{/if}

<style lang="scss">
.name {
.presenter-label {
overflow: hidden;
display: inline-flex;
align-items: center;
flex-shrink: 1;
min-width: 1rem;

Expand Down
2 changes: 1 addition & 1 deletion tests/sanity/tests/tracker.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export async function checkIssueFromList (page: Page, issueName: string): Promis
}

export async function openIssue (page: Page, name: string): Promise<void> {
await page.click(`.antiList__row:has-text("${name}") .name a`, {
await page.click(`.antiList__row:has-text("${name}") .presenter-label a`, {
timeout: 15000
})
}