Tracker: Issues list view #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiodo
reviewed
Apr 7, 2022
models/tracker/src/index.ts
Outdated
| @@ -101,7 +101,7 @@ export class TIssue extends TDoc implements Issue { | |||
| @Prop(Collection(attachment.class.Attachment), tracker.string.Attachments) | |||
| attachments!: number | |||
|
|
|||
| // @Prop(Collection(core.class.TypeString), tracker.string.Labels) | |||
| @Prop(Collection(core.class.TypeString), tracker.string.Labels) | |||
There was a problem hiding this comment.
Better to declare special LabelType with appropriate presenters.
haiodo
reviewed
Apr 7, 2022
| @@ -0,0 +1,45 @@ | |||
| <!-- | |||
| // Copyright © 2020, 2021 Anticrm Platform Contributors. | |||
| // Copyright © 2021 Hardcore Engineering Inc. | |||
haiodo
reviewed
Apr 7, 2022
| import view from '@anticrm/view' | ||
| import tracker from '../../plugin' | ||
|
|
||
| export let value: Employee |
There was a problem hiding this comment.
Suggested change
| export let value: Employee | |
| export let value: WithLookup<Employee> | |
| // and show value.lookup.assignee |
haiodo
reviewed
Apr 7, 2022
| { key: '', presenter: tracker.component.TitlePresenter }, | ||
| { key: '', presenter: tracker.component.LabelsPresenter }, | ||
| { key: 'modifiedOn', presenter: tracker.component.ModificationDatePresenter }, | ||
| '$lookup.assignee' |
There was a problem hiding this comment.
{ key: '$lookup.assignee', props: { showText: false } }
Please check view-resources implementation buildModel()
haiodo
reviewed
Apr 7, 2022
plugins/tracker-resources/src/components/issues/ControlCheckBox.svelte
Outdated
Show resolved
Hide resolved
haiodo
reviewed
Apr 7, 2022
plugins/tracker-resources/src/components/issues/IssuesList.svelte
Outdated
Show resolved
Hide resolved
haiodo
reviewed
Apr 7, 2022
plugins/tracker-resources/src/components/issues/ModificationDatePresenter.svelte
Show resolved
Hide resolved
agrigorovich-xored
force-pushed
the
feature-1268
branch
from
bee02a4 to
169f453
Compare
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
agrigorovich-xored
force-pushed
the
feature-1268
branch
from
169f453 to
bb77453
Compare
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
…signeePresenter Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com>
haiodo
approved these changes
Apr 8, 2022
| @@ -1,19 +0,0 @@ | |||
| { | |||
| "files.exclude": { | |||
| /> | ||
| </Scroller> | ||
| <Scroller> | ||
| <IssuesList |
There was a problem hiding this comment.
Probable we should rename IssuesList to ListView and put it inside view/view-resources
budaeva
pushed a commit
that referenced
this pull request
Apr 13, 2022
Signed-off-by: Artyom Grigorovich <grigorovichartyom@gmail.com> Signed-off-by: budaeva <irina.budaeva@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.