Add modal with links to matches for classification entries (#656) #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get `exactMatch` and `narrowMatch` from SKOS, add to `matches`
|
Die nötige Funktionalität ist umgesetzt. Hier noch ein paar Verbesserungsvorschläge:
|
- Display button as link - Don't include number of links - Show icons for DNB and Wikidata
|
Die Position des Modals (aus Bootstrap) kann man offenbar nicht anpassen. Die anderen Punkte (Button als Link, keine Zahl, Icons) sind auf Test deployed: |
acka47
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #656.
Deployed to test: https://test.nwbib.de/subjects