Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback for publication dates #2089 #2091

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix fallback for publication dates #2089 #2091

merged 1 commit into from
Nov 7, 2024

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Nov 5, 2024

Related to #2089

Deletes the not needed brackets that lead to overwriting the publication dates from "264 by 008

@TobiasNx TobiasNx requested a review from maipet November 5, 2024 08:50
@TobiasNx TobiasNx changed the title Add new test 99374153235806441 Fix fallback for publication dates #2089 Nov 5, 2024
@maipet maipet assigned TobiasNx and unassigned maipet Nov 5, 2024
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Nov 5, 2024

This fix fails therefore it is not ready. #2090 needs to be merged first.

The testfile fails the JSON SCHEMA validation due to natureOfContent.id being wrong this would be fixed by: bb77c45

Due to wrong pathname 008 has overwritten correct publication dates.
@TobiasNx TobiasNx changed the base branch from master to 2082-LookupGnd2Formangabe November 6, 2024 10:34
@TobiasNx TobiasNx requested a review from maipet November 6, 2024 10:34
@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Nov 6, 2024
@TobiasNx TobiasNx requested a review from dr0i November 6, 2024 12:13
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Nov 6, 2024

I assigned @dr0i for final review and merging.

Base automatically changed from 2082-LookupGnd2Formangabe to master November 7, 2024 08:59
@dr0i dr0i merged commit eccffd1 into master Nov 7, 2024
1 check passed
@dr0i dr0i deleted the 2089-pubDate branch November 7, 2024 09:02
@dr0i
Copy link
Member

dr0i commented Nov 7, 2024

Deployed next Monday. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants