Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nwbib ttl for nwbib spatial und subjects labels #1905

Closed
TobiasNx opened this issue Sep 25, 2023 · 3 comments
Closed

Use nwbib ttl for nwbib spatial und subjects labels #1905

TobiasNx opened this issue Sep 25, 2023 · 3 comments
Assignees

Comments

@TobiasNx
Copy link
Contributor

Instead of mapping the labels with the src/main/resources/labels/labels.json maker, we could use the ttl files from the upcoming submodule for lobid-vocabs. #1902

Then we could delete them from the labels.json file. As well as the RPB (lbz notationen) labels.

@TobiasNx
Copy link
Contributor Author

@acka47 it seems that the nwbib labels are unnecessary, see #1912.

Are they always provided via the marc record?

  • Would it be better to use the ttl-file from nwbib since the labels are more up to date?
  • Should we use it only as fallback?
  • Is an additional adding of nwbib-labels unnecessary since the source data from ZDB is always correct and complete (id and label)?

@TobiasNx TobiasNx moved this from Backlog to Ready in lobid-resources Sep 27, 2023
@acka47
Copy link
Contributor

acka47 commented Sep 27, 2023

  • Would it be better to use the ttl-file from nwbib since the labels are more up to date?

I think so.

  • Should we use it only as fallback?

Do we need a fallback?

  • Is an additional adding of nwbib-labels unnecessary since the source data from ZDB is always correct and complete (id and label)?

We know that the source data isn't always correct for CZ-derived electronical ZDB/EZB resources.

@acka47 acka47 assigned TobiasNx and unassigned acka47 Sep 27, 2023
TobiasNx added a commit that referenced this issue Sep 27, 2023
Instead of the source data labels in $a. The ttl File will be more up date and are provided as submodule lobid-vocabs
@TobiasNx TobiasNx moved this from Ready to Done in lobid-resources Oct 2, 2023
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Oct 4, 2023

Label in http://lobid.org/resources/990110714900206441.json are updated. So it is productive.

@TobiasNx TobiasNx closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants