-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALMA test xmls are not valid MARCXML #1348
Comments
But our ETL is working with it. |
ah, uh - and use |
Thanks. But the option behaviour seems odd and is not documented: This should somehow be documented since normally this would be "tru"/"false" |
Of course it's documented:
You can either set it to
This only applies to |
Oh, did you mean the part about disabling the namespace check? Then you're right, that's currently not documented. Sorry if I misunderstood. |
@TobiasNx can you document it? |
Update documentation for namespace handling in decode-marcxml. See: hbz/lobid-resources#1348 (comment)
This issue is related to metafacture/metafacture-core#569. |
While we can work with the marc data from lobid with metafacture now, due to the adjustemts made in metafacture/metafacture-core#569 . The marc data is still not valid. But since the alma publishing data is part of our records one could argue the data is no "pure" marc xml. So we could still add the namespace to the marc xml records OR just put this on wont fix until somebody asks for it. |
Won't fix atm as discussed in our meeting. Closing. |
See here
The problem is, that the namespace is not provided in the marc xml files:
https://github.com/hbz/lobid-resources/blob/b1b8a24d6958026a2adebf1ff607a6ec9dd664aa/src/test/resources/alma
It s:
<record>
Should be:
<record xmlns="http://www.loc.gov/MARC21/slim">
If there is a
<collection>
element as in https://github.com/hbz/lobid-resources/blob/4fbc7cfa76792bc5730f19a17f2292d24ab515ac/src/test/resources/alma/almaMarcXmlTestFiles.xml.tar.bz2 then the namespace should include the namespace refrence not the<record>
element.It s:
<collection><record>
Should be:
<collection xmlns="http://www.loc.gov/MARC21/slim"><record>
Because of this the playground as well as other Flux-Scripts do not recognize the files without the namespace as marc-xml.
The text was updated successfully, but these errors were encountered: