Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filtering based on GND ontology types #8

Closed
acka47 opened this issue Jul 12, 2017 · 6 comments
Closed

Enable filtering based on GND ontology types #8

acka47 opened this issue Jul 12, 2017 · 6 comments

Comments

@acka47
Copy link
Contributor

acka47 commented Jul 12, 2017

Moved here with some adjustments from lobid/lodmill#447.

Example query: "heinsberg"

Facets/possibilities for filtering by secend-level types:

  • Person
  • Subject Heading
  • Place or Geographic Name
  • Converence or Event
  • Family
  • Corporate Body
  • Work

(Similar to e.g. https://portal.dnb.de/opac.htm?method=simpleSearch&query=heinsberg)

Clicking a facet should yield filtered search results with sub-facets, e.g.:

Place or Geographic Name:

  • Building or Memorial
  • Administrative Unit
  • Fictive Place
  • ...
@fsteeg
Copy link
Member

fsteeg commented Aug 15, 2017

Deployed to test: http://test.lobid.org/authorities/search

@fsteeg fsteeg assigned ChristophEwertowski and unassigned fsteeg Aug 15, 2017
@fsteeg fsteeg added review and removed working labels Aug 15, 2017
@ChristophEwertowski
Copy link
Contributor

The type "Family" is missing at the collection of second-level types. And drilling-down facets isn't implemented right, see query where are "Works" under "Persons".

fsteeg added a commit that referenced this issue Aug 16, 2017
@fsteeg
Copy link
Member

fsteeg commented Aug 16, 2017

The type "Family" is missing at the collection of second-level types.

Fixed on test: http://test.lobid.org/authorities/search

And drilling-down facets isn't implemented right, see query where are "Works" under "Persons".

The faceted search shows all types for the selected result list, which has entries with both Work and Person. If that's not right it's a data issue in the GND, see e.g. http://d-nb.info/gnd/1049620550

@fsteeg fsteeg assigned ChristophEwertowski and unassigned fsteeg Aug 16, 2017
@ChristophEwertowski
Copy link
Contributor

Mmh, I searched for the person of the example and filtered it for Person at the GND. After this there is no possiblity to filter with other facets. So I think it's okay. Anyhow I'm assigning it to acka47 because I'm not sure I understood it right.

@acka47
Copy link
Contributor Author

acka47 commented Aug 21, 2017

+1

The problems mentioned are due to obviously incorrect typing in the GND (see e.g. http://test.lobid.org/authorities/search?q=%22Dialogues+socratiques+ou+entretiens+sur+divers+sujets+de+morale%22).

@acka47 acka47 removed their assignment Aug 21, 2017
@acka47
Copy link
Contributor Author

acka47 commented Aug 21, 2017

Closing.

@acka47 acka47 closed this as completed Aug 21, 2017
@acka47 acka47 removed the review label Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants