Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blank node ids #4

Closed
acka47 opened this issue Jul 4, 2017 · 2 comments
Closed

Remove blank node ids #4

acka47 opened this issue Jul 4, 2017 · 2 comments

Comments

@acka47
Copy link
Contributor

acka47 commented Jul 4, 2017

From #1 (comment):

Re. the framing output from http://tinyurl.com/ychm4t92, I just noticed that blank nodes get an id:

     "hasGeometry": {
       "@id": "_:b0",
       "@type": "http://www.opengis.net/ont/sf#Point",
       "asWKT": "Point ( -000.125740 +051.508530 )"
     }

We should get rid of them. This has already been addressed in the JSON-LD Framing spec 1.1 ("pruneBlankNodeIdentifiers") but is currently only implemented in the Ruby library, see json-ld/json-ld.org#293.
@acka47 acka47 added the ready label Jul 4, 2017
@fsteeg fsteeg added working and removed ready labels Jul 18, 2017
fsteeg added a commit that referenced this issue Jul 19, 2017
@fsteeg
Use patched jsonld-java version to remove blank node IDs
1f8aab0 
See #4
fsteeg added a commit that referenced this issue Jul 19, 2017
@fsteeg
Use patched jsonld-java version to remove blank node IDs
a9e5326 
See #4
@fsteeg
Copy link
Member

fsteeg commented Jul 25, 2017

Deployed to test: http://test.lobid.org/authorities/4074335-4.json

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jul 25, 2017
@fsteeg fsteeg added review and removed working labels Jul 25, 2017
@acka47
Copy link
Contributor Author

acka47 commented Jul 25, 2017

+1

@acka47 acka47 removed their assignment Jul 25, 2017
@fsteeg fsteeg closed this as completed Jul 26, 2017
@fsteeg fsteeg removed the review label Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fsteeg @acka47