Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip generic accessors to user-defined points and point coordinates #5

Merged
merged 3 commits into from
May 4, 2013

Conversation

hbf
Copy link
Owner

@hbf hbf commented Apr 18, 2013

Currently, the code requires copying the input points to an internal vector. With this WIP, the code accesses the input points through accessors, allowing user-defined points to be used without copying them.

It may, of course, in some cases be faster to copy the points to a vector, but this is now a decision the user can take.

Kaspar Fischer (hbf) added 2 commits April 18, 2013 23:34
needs some review and simplication:
- rename PointAccessor
- how can points be "inserted" afterwards?
@hbf
Copy link
Owner Author

hbf commented Apr 18, 2013

Code needs some review and potentially simplification:

  • Rename PointAccessor
  • How can points be "inserted" once the computation has run?

hbf added a commit that referenced this pull request May 4, 2013
Wip generic accessors to user-defined points and point coordinates
@hbf hbf merged commit d53c9f9 into master May 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant