forked from apple/servicetalk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable auto ack for HTTP/2 PING frames by netty (apple#1558)
Motivation: `KeepAliveManager#pingReceived` always acks PING frames. Netty's auto ack produces additional PING-ack frames that are not necessary and confusing. Modifications: - Use `Http2FrameCodecBuilder#autoAckPingFrame(false)` on client and server sides; Result: No duplicated PING frames written with ack=true.
- Loading branch information
1 parent
c9318c7
commit 26a2f08
Showing
3 changed files
with
7 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters