Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: v0.5.0 breaks compatibilty with Kong <= 1.2 #59

Closed
hbagdi opened this issue Aug 20, 2019 · 0 comments · Fixed by #64
Closed

Bug: v0.5.0 breaks compatibilty with Kong <= 1.2 #59

hbagdi opened this issue Aug 20, 2019 · 0 comments · Fixed by #64
Labels
bug Something isn't working priority/high
Milestone
v0.5.1

Comments

@hbagdi
Copy link
Member

hbagdi commented Aug 20, 2019

Kong version before 1.3 do not have ca_certificate entity and an attempt to sync this entity results in an error.
@hbagdi hbagdi added the bug Something isn't working label Aug 20, 2019
@eamonnmcevoy eamonnmcevoy mentioned this issue Aug 20, 2019
Closed
@hbagdi hbagdi added this to the v0.5.1 milestone Aug 20, 2019
hbagdi added a commit that referenced this issue Aug 20, 2019
@hbagdi
fix(dump) fix compatibility for Kong < 1.3
c1d9fff 
CACertificate core entitiy was not present in the past
and the Admin API request will error with 404 Not Found for older
versions of Kong.
If we do get a 404 from Kong, instead of erroring out,
return back an empty array of
CACertificates, effectively disabling the entity for versions
which don't have it.
A better solution would be to have a version check, and based
on the version, the entities are loaded and synced.

Fix #59
@hbagdi hbagdi mentioned this issue Aug 20, 2019
Merged
hbagdi added a commit that referenced this issue Aug 20, 2019
@hbagdi
fix(dump) fix compatibility for Kong < 1.3
93c7db5 
CACertificate core entitiy was not present in the past
and the Admin API request will error with 404 Not Found for older
versions of Kong.
If we do get a 404 from Kong, instead of erroring out,
return back an empty array of
CACertificates, effectively disabling the entity for versions
which don't have it.
A better solution would be to have a version check, and based
on the version, the entities are loaded and synced.

Fix #59
From #64
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
fix(dump) fix compatibility for Kong < 1.3
c2d1f40 
CACertificate core entitiy was not present in the past
and the Admin API request will error with 404 Not Found for older
versions of Kong.
If we do get a 404 from Kong, instead of erroring out,
return back an empty array of
CACertificates, effectively disabling the entity for versions
which don't have it.
A better solution would be to have a version check, and based
on the version, the entities are loaded and synced.

Fix #59
From #64
AntoineJac pushed a commit that referenced this issue Jan 23, 2024
@hbagdi
fix(dump) fix compatibility for Kong < 1.3
f8149b2 
CACertificate core entitiy was not present in the past
and the Admin API request will error with 404 Not Found for older
versions of Kong.
If we do get a 404 from Kong, instead of erroring out,
return back an empty array of
CACertificates, effectively disabling the entity for versions
which don't have it.
A better solution would be to have a version check, and based
on the version, the entities are loaded and synced.

Fix #59
From #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority/high
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging a pull request may close this issue.

fix(dump) fix compatibility for Kong < 1.3 Kong/deck
1 participant
@hbagdi