fix(dump) fix compatibility for Kong < 1.3 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CACertificate core entitiy was not present in the past and the Admin API request will error with 404 Not Found for older versions of Kong. If we do get a 404 from Kong, instead of erroring out, return back an empty array of CACertificates, effectively disabling the entity for versions which don't have it. A better solution would be to have a version check, and based on the version, the entities are loaded and synced. Fix #59
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
CACertificate core entitiy was not present in the past and the Admin API request will error with 404 Not Found for older versions of Kong. If we do get a 404 from Kong, instead of erroring out, return back an empty array of CACertificates, effectively disabling the entity for versions which don't have it. A better solution would be to have a version check, and based on the version, the entities are loaded and synced. Fix #59 From #64
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
CACertificate core entitiy was not present in the past and the Admin API request will error with 404 Not Found for older versions of Kong. If we do get a 404 from Kong, instead of erroring out, return back an empty array of CACertificates, effectively disabling the entity for versions which don't have it. A better solution would be to have a version check, and based on the version, the entities are loaded and synced. Fix #59 From #64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CACertificate core entitiy was not present in the past
and the Admin API request will error with 404 Not Found for older
versions of Kong.
If we do get a 404 from Kong, instead of erroring out,
return back an empty array of
CACertificates, effectively disabling the entity for versions
which don't have it.
A better solution would be to have a version check, and based
on the version, the entities are loaded and synced.
Fix #59