Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed async profiler installation problems #2213

Merged
merged 1 commit into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions performance_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ Make sure you have added the following JVM settings:

And to run, execute the following if you want a `JFR` file which can be analyzed with Java Mission Control:
```shell
profiler.sh collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -f profile.jfr Worker
asprof collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -f profile.jfr Worker
```

Use the following for more accurate profiling:
```shell
profiler.sh collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -e cycles --cstack lbr -f profile.jfr Worker
asprof collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -e cycles --cstack lbr -f profile.jfr Worker
```

Or use the following if you do not care for a jfr file but want a flamegraph directly:
```shell
profiler.sh collect -d 60 -f flamegraph.html Worker
asprof collect -d 60 -f flamegraph.html Worker
```

# Perf
Expand Down
3 changes: 1 addition & 2 deletions playbooks/install_async_profiler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
lineinfile:
dest: ~{{ console_user | default(ansible_user) }}/.bashrc
state: present
line: "export PATH=$ASYNC_PROFILER_HOME/:$PATH"
line: "export PATH=$ASYNC_PROFILER_HOME/bin/:$PATH"
insertbefore: BOF

- name: Update ASYNC_PROFILER_HOME
Expand All @@ -49,4 +49,3 @@
line: "export ASYNC_PROFILER_HOME=~{{ console_user | default(ansible_user) }}/{{ archive_contents.files[0].split('/')[0] }}"
insertbefore: BOF