Skip to content

Commit

Permalink
Fixed async profiler installation problems
Browse files Browse the repository at this point in the history
  • Loading branch information
pveentjer committed Apr 5, 2024
1 parent 40f83cc commit 2c4ca58
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
6 changes: 3 additions & 3 deletions performance_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ Make sure you have added the following JVM settings:

And to run, execute the following if you want a `JFR` file which can be analyzed with Java Mission Control:
```shell
profiler.sh collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -f profile.jfr Worker
asprof collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -f profile.jfr Worker
```

Use the following for more accurate profiling:
```shell
profiler.sh collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -e cycles --cstack lbr -f profile.jfr Worker
asprof collect -d 60 --jfrsync ${JAVA_HOME}/lib/jfr/default.jfc -e cycles --cstack lbr -f profile.jfr Worker
```

Or use the following if you do not care for a jfr file but want a flamegraph directly:
```shell
profiler.sh collect -d 60 -f flamegraph.html Worker
asprof collect -d 60 -f flamegraph.html Worker
```

# Perf
Expand Down
3 changes: 1 addition & 2 deletions playbooks/install_async_profiler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
lineinfile:
dest: ~{{ console_user | default(ansible_user) }}/.bashrc
state: present
line: "export PATH=$ASYNC_PROFILER_HOME/:$PATH"
line: "export PATH=$ASYNC_PROFILER_HOME/bin/:$PATH"
insertbefore: BOF

- name: Update ASYNC_PROFILER_HOME
Expand All @@ -49,4 +49,3 @@
line: "export ASYNC_PROFILER_HOME=~{{ console_user | default(ansible_user) }}/{{ archive_contents.files[0].split('/')[0] }}"
insertbefore: BOF


2 changes: 1 addition & 1 deletion src/agents_clean.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ def _agent_clear(agent):

def agents_clean(agents):
info(f"Clearing agents: starting")
run_parallel(_agent_clear, [(agent,) for agent in agents])
# run_parallel(_agent_clear, [(agent,) for agent in agents])
info(f"Clearing agents: done")

0 comments on commit 2c4ca58

Please sign in to comment.